Pointer Problem

The following program defines a function that is supposed to return a pointer of a string variable to the main program. Strangely, the program compiles but crashes when it runs. It crashes where it attempts to derefrerence the pointer in the main program.

Please assist:

#include <iostream>
#include <conio.h>
#include <string>

using namespace std;

string *acceptName() {
string name;
cin>> name;

return &name;
}

int main() {
string *name (acceptName());

cout<< "Your name is "<< *name<< endl;
getche();
return 0;
}


Shupi

"Local variables are destroyed and their memory reclaimed at the end of the enclosing block." - cprogramming.com
That means that you are making reference to a memory location that does not exist anymore. One way to get around this is to use a global variable as in the next example.

#include <iostream>
#include <string>
using namespace std;

string name;

string *acceptName(){
cout << "Name:";
cin>> name;
return &name;
};

int main() {
string *name;
name = acceptName();

cout<< "Your name is "<< *name<< endl;
return 0;
}


This works fine - but as you know Global varaibles is not such a good idea.I will look for some more ways to work around this.

Thanks buddie, it had never occurred to me to consider a global variable.

However, like what u said, the use of a global variable may not be the best solution if ever there is another way to do it.

Cheers,

Shupi

this should fix your problem without the use of global variables

#include <iostream>
#include <string>

using namespace std;

string *acceptName() 
{
	string *name = new string;
	cout << "Enter name: ";
	getline(cin, *name, '\n';  //  or cin >> *name;	
	return name;
}

void main() 
{
	string *name(acceptName());
	cout<< "Your name is "<< *name << endl;
        delete name;
}